-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Colour handling improvements #8702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The replacement library from https://colorjs.io/ is much, much larger but I think we can develop a custom build that uses treeshaking to whittle the code down to the bits that we need. @linonetwo does that sound feasible? I intend the explore further improvements but I wanted to start by establishing a library that can do modern P3 and OKLCH colour calculations.
Really just syntactic sugar for the wikify widget
Using the new wikify operator. Currently has a bug whereby redirected colours (like "tiddler-background") do not work. Direct colours like "background" do work. Note the hacks needed to makeFakeWidgetWithVariables work
|
Confirmed: Jermolene has already signed the Contributor License Agreement (see contributing.md) |
|
Is there a demo to test colour handling improvement? |
Hi @kookma I've posted a preview to tiddlyhost |
|
@Jermolene ... There is a PR the ESLint const spacing problem. |
✅ Change Note StatusAll change notes are properly formatted and validated! 📝 $:/changenotes/5.4.0/#8702Type: enhancement | Category: hackability
🔗 #8702 👥 Contributors: Jermolene 📖 Change Note GuidelinesChange notes help track and communicate changes effectively. See the full documentation for details. |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2451.3 KB |
| PR | 2462.6 KB |
Diff: ⬆️ Increase: +11.3 KB
✅ Change Note StatusAll change notes are properly formatted and validated! 📝 $:/changenotes/5.4.0/#8702Type: enhancement | Category: hackability
🔗 #8702 👥 Contributors: Jermolene 📖 Change Note GuidelinesChange notes help track and communicate changes effectively. See the full documentation for details. |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2451.3 KB |
| PR | 2462.6 KB |
Diff: ⬆️ Increase: +11.3 KB
✅ Change Note StatusAll change notes are properly formatted and validated! 📝 $:/changenotes/5.4.0/#8702Type: enhancement | Category: hackability
🔗 #8702 👥 Contributors: Jermolene 📖 Change Note GuidelinesChange notes help track and communicate changes effectively. See the full documentation for details. |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2448.0 KB |
| PR | 2459.3 KB |
Diff: ⬆️ Increase: +11.3 KB
Introduction
This PR brings several new features for end users:
There are also new capabilities for palette authors:
To make all of these new features possible, this PR also includes some useful new general purpose mechanisms and features:
$:/info/...tiddlerchangecountfilter operator:applyfilter run prefixTry the Demo
A preview build is available at https://deploy-preview-8702--tiddlywiki-previews.netlify.app/
Changes to Palettes
Palette entries are now defined as filters that must be evaluated, rather than wikitext that must be wikified.
This makes it possible to create palettes that reference and modify other colours. For example:
Retrospectively re-interpreting palettes entries as filters would normally mean that
<<colour background>>would no longer work. Instead these entries are automatically converted to the updated form[function[colour],[background]].Palette Compilation
The key idea underpinning these changes is a fundamental change to the way that TiddlyWiki handles palettes. At the moment, palette entries are named items that can contain either a CSS colour string, a CSS colour token like "inherit", or can use the
<<colour>>macro to reference another colour palette entry. Thus, palette entries have to be wikified before they can be used. This has turned out to be very limiting and doesn't provide a viable path to the complex colour manipulations shown above. Switching to filters might make things worse, by encouraging authors to use complex expressions within palettes.The fix is compiled palettes: at the point of switching to a new palette, the colours within it are "compiled" to raw CSS colour values (typically but not necessarily in
#rrggbbaaformat). This allows palette entries to be used directly, without the requirement to wikify them.The static palette is created in a new system tiddler
$:/temp/palette-coloursby an action procedure that is invoked at startup and when switching to a new palette.There should not be any backwards compatibility issues because the use of background actions means that any code that changes
$:/palettewill automatically trigger the recompilation of the palette.This change also allows us to change the
<<colour>>procedure to be a function, which allows it to be used as the value for a style attribute:Automatic Palette Readability Tests
Palettes can opt to include readability tests as special palette entries. The results of these tests are shown at the bottom of the palette chooser. For example:
The test framework looks for palette entries starting with a question mark and runs the associated filters. The filter should return nothing if there are no errors, or a textual error message if the conditions are violated. Sample output:
Colour Manipulation
We need a colour manipulation library that can calculate variants of colours. Only color.js met the requirements of being able to work with P3 colours and the OKLCH colour space. It also includes a CSS colour string parser which can replace the simple one that TiddlyWiki has always incorporated.
Media Query Tracker
The CSS media query tracker allows a media query to be bound to an info tiddler so that the current state of the query is reflected in the value of the tiddler. The value is updated dynamically.
The use of the info mechanism for the CSS media query tracker means that these tiddlers are dynamically created as shadow tiddlers within the
$:/temp/infoplugin, and so do not appear in tiddler lists.The mechanism is used to implement the existing dark mode tiddler with the following configuration:
Note the use of
info-tiddler-altto specify a redundant secondary info tiddler. This is used by the dark mode tracker to maintain compatibility while changing the info tiddler title for consistency.Background Actions
The new background actions mechanism allows action strings to be invoked automatically in the background whenever the results of a filter change.
The preview includes a demonstration background action that displays an alert with a list of tiddlers in the story river whenever the story river changes:
applyFilter Run PrefixAn experimental new filter run prefix that makes it possible to use computed values as variables within a filter run. For example:
Backwards Compatibility
$:/PaletteManageris moved into$:/PaletteEditor, and$:/PaletteManagerrepurposed as the control panel palette switcher$:/config/DefaultColourMappings/now only supports CSS colours, and not indirections via<<colour X>>or[function[colour],[X]]References
Progress
changecountoperatorcolour-interpolateoperatorcolour-lightenoperatorcolour-darkenoperatorcolour-get-oklchoperatorcolour-set-oklchoperatorcolour-contrastoperatorcolour-best-contrastoperator